fast-generic-serializer supports 'enum' and 'fixed' types #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with enum and fixed fields. For now marked as ignored e.g. due to: class com.linkedin.avro.fastserde.generated.avro.JustSimpleEnum cannot be cast to class org.apache.avro.generic.GenericData$EnumSymbol
with 'enum' and 'fixed' types.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
=========================================
Coverage 45.82% 45.83%
- Complexity 4441 4442 +1
=========================================
Files 398 398
Lines 28040 28040
Branches 4622 4622
=========================================
+ Hits 12850 12851 +1
Misses 13634 13634
+ Partials 1556 1555 -1 ☔ View full report in Codecov by Sentry. |
FelixGV
reviewed
Sep 12, 2023
Comment on lines
-304
to
+301
| ifBlock = ifBlock != null ? ifBlock._elseif(condition) : body._if(condition); | ||
| ifBlock = body._if(condition); |
There was a problem hiding this comment.
What is the rationale for this change?
There was a problem hiding this comment.
Let's consider two key facts:
- For the first time we enter this block
ifBlockisnull - The block can be entered at most once due to
breakat the end.
It means condition ifBlock != null is always false.
"Always" in this context means "at most once".
There was a problem hiding this comment.
I see. That's right... I missed that detail when I refactored this code in 608bce8
FelixGV
approved these changes
Sep 13, 2023
Comment on lines
-304
to
+301
| ifBlock = ifBlock != null ? ifBlock._elseif(condition) : body._if(condition); | ||
| ifBlock = body._if(condition); |
There was a problem hiding this comment.
I see. That's right... I missed that detail when I refactored this code in 608bce8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to fix scenario when fast-generic-serializer serializes specific record with fields of type 'enum' and/or 'fixed'.
The 4th commit it the most important one and its message (
[fast-avro] Now fast-generic-serializer supports records with 'enum' and 'fixed' types.) might be used after squash.1st and 2nd commit are self-explanatory, just to avoid pollution of the main commit.
Other commits were pushed just to present differences in the generated code.
Example stacktrace before: